Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use strings.Builder in endingToString #1506

Merged
merged 1 commit into from Nov 6, 2023
Merged

Use strings.Builder in endingToString #1506

merged 1 commit into from Nov 6, 2023

Conversation

tmthrgd
Copy link
Collaborator

@tmthrgd tmthrgd commented Nov 6, 2023

This will cause one less allocation as String allocates on a bytes.Buffer but not on a strings.Builder.

@tmthrgd
Use strings.Builder in endingToString
e3221c3 
This will cause one less allocation as String allocates on a
bytes.Buffer but not on a strings.Builder.
@tmthrgd tmthrgd requested a review from miekg as a code owner November 6, 2023 05:51
@miekg miekg merged commit a16092f into miekg:master Nov 6, 2023
4 checks passed
@tmthrgd tmthrgd deleted the endingToString_strings.Builder branch November 6, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miekg miekg Awaiting requested review from miekg miekg is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tmthrgd @miekg