Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom paths for exports can result in invalid files in Windows #1790

Closed
5 tasks done
t3dotgg opened this issue Nov 27, 2023 · 3 comments
Closed
5 tasks done

Custom paths for exports can result in invalid files in Windows #1790

t3dotgg opened this issue Nov 27, 2023 · 3 comments
Labels

Comments

@t3dotgg
Copy link
Sponsor

t3dotgg commented Nov 27, 2023

I have a lot of issues to go through, so in order to make it easier for me to help you, I ask that you please try these things first

Operating System

Windows 10

Steps to reproduce

Hey y'all! Had a few issues where certain characters sneak into path names and break things badly in Windows. Biggest causes are spaces at end of file names and "..."

image

Expected behavior

File paths should be valid

Actual behavior

File paths are invalid and break windows

Share log

No response

@mifi
Copy link
Owner

mifi commented Dec 1, 2023

Hi! This is with "No sanitize" right? (in the output file name template export settings):
Screenshot 2023-12-02 at 00 17 16

I think we could indeed still add some sanitazion even for the "no sanitize" mode. Do you have any concrete examples of file names that failed? I see that your screenshot has a file named 09 - End_of_Prime_reacts_to_is - but I cannot see any .. or trailing space there. And I cannot find any documentation saying the file names on windows cannot contain .. or trailing space.

what does the output look like in the "preview" button dialog?

@mifi mifi added the Windows label Dec 2, 2023
@t3dotgg
Copy link
Sponsor Author

t3dotgg commented Dec 4, 2023

This is happening with sanitize on sadly

@mifi mifi closed this as completed in aa1958c Dec 5, 2023
@mifi
Copy link
Owner

mifi commented Dec 5, 2023

I have now changed logic when sanitize is on:

  • disallow both forward and backward slashes on windows
  • disallow file name ending with a space or a dot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants