Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full support for dark theme #733

Closed
SameExpert opened this issue Apr 22, 2021 · 7 comments
Closed

Full support for dark theme #733

SameExpert opened this issue Apr 22, 2021 · 7 comments

Comments

@SameExpert
Copy link

Is your feature request related to a problem? Please describe.
On Linux (KDE Plasma) I'm having dark theme. It looks odd if LosslessCut stays out light-themed when everything else is dark.

Describe the solution you'd like
LosslessCut should support for dark mode. There can be an option in settings for Dark mode / Light mode / System default (if possible)

Describe alternatives you've considered
As it depends on gtk3, system's GTK settings should be used.

@mifi
Copy link
Owner

mifi commented May 5, 2021

losslesscut is a cross platform app so it doesn't use native widgets like GTK. it could however try to follow colors. however losslesscut UI is already rather dark. can you provide a screenshot of what you mean by It looks odd if LosslessCut stays out light-themed when everything else is dark. ?

@SameExpert
Copy link
Author

The main windows is OK (even though it's tool-tips are brightened it's not much). But this window is so brightened and doesn't suite for dark themes:
Screenshot__1

@mifi mifi changed the title [UI] Support for dark theme Full support for dark theme Jan 15, 2022
@Mitch037
Copy link

Any chance we ever get dark mode in LosslessCut?

@mifi
Copy link
Owner

mifi commented Dec 18, 2022

The problem is that the UI components of evergreen-ui don’t look very good on a dark background. But as evergreen now has theming support, I think we could define a dark theme.

if someone wants to try to make a dark theme for evergreen that would be a start

https://evergreen.segment.com/introduction/theming

@mifi mifi closed this as completed in 9b027bc Mar 10, 2023
@mkibp
Copy link

mkibp commented Apr 3, 2024

Am I blind or is the dark mode config setting not exposed anywhere in the UI settings?

@mifi
Copy link
Owner

mifi commented Apr 3, 2024

lower left
Screenshot 2024-04-03 at 22 38 54

@mkibp
Copy link

mkibp commented Apr 8, 2024

Ahhh, in advanced view, thank you. Though I suggest considering perhaps adding it somewhere to the settings view too for completeness sake

@mifi mifi mentioned this issue Apr 18, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants