Milestone1 list structure #1
Conversation
There was a problem hiding this comment.
CHANGES REQUIRED 🔴 🛑
Hello @miftah1991, great job you are doing so far in this project. 💯
TO HIGHLIGHT:
- Your project is professional
- Your repo is professional
- Well structured files
- Your app is working properly
However, there are a few changes to make to move to the next project 🛠️ . Keep working hard 💪 💻
Required Changes ♻️
See my inline comment to know what changes are needed. 👇 👀
Please make these required changes and send it again for another review 👍 💪
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
HAPPY CODING!!! 😄
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
src/index.js
Outdated
| const tasksDisplay = () => { | ||
| const inputItem = document.querySelector('#input-item'); | ||
| tasks.reverse().forEach((task) => { | ||
| const html = ` | ||
| <li class="task-${task.index}"> | ||
| <div class="task"> | ||
| <input type="checkbox" name="task"> ${task.description} | ||
| </div> | ||
| <i class="fas fa-ellipsis-v three-dot-icon"></i> | ||
| </li> | ||
| `; | ||
| inputItem.insertAdjacentHTML('afterend', html); | ||
| }); | ||
| }; | ||
| tasksDisplay(); |
There was a problem hiding this comment.
- It would be better if the tasks appear in order of the index.
Currently, your tasks are in disorder. Kindly fix this minor issue.
There was a problem hiding this comment.
Hi @miftah1991 ,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
|
Thanks for your review. |
This is the first milestone of the to-do list project in this milestone below features are added.
webpackfor the projecttodoitems