Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Option to disable dictionary radicals #29

Closed
RicBent opened this issue Oct 27, 2021 · 4 comments
Closed

[FEATURE] Option to disable dictionary radicals #29

RicBent opened this issue Oct 27, 2021 · 4 comments
Assignees
Labels
enhancement Enhancment of an existing feature python Involves work in Python requires discussion Either complex, underdeveloped, or possibly contentious

Comments

@RicBent
Copy link
Contributor

RicBent commented Oct 27, 2021

Generally dictionary radicals aren't really useful for most learners.

An option should be added that allows toggling the radical section.

By default it should be disabled as the difference between primitives and radicals would just throw off beginners.

@RicBent RicBent added the enhancement Enhancment of an existing feature label Oct 27, 2021
@RicBent RicBent self-assigned this Oct 27, 2021
@saxoncameron
Copy link
Contributor

Hey @RicBent since we've got a couple issues now related to show/hiding sections, what do you think about a new tab in settings for toggling show/hide on any/all sections? We've had a number of requests from users to customise what's displayed, since there's a tonne of info on the cards.

A simple way to implement this would be for me to make a class name apply display: none to the container, then your options could just selectively add class="-hide" to each of the containers.

Then we could just have this the only section that's hidden by default.

@saxoncameron
Copy link
Contributor

Also a note, that however this ends up in the settings panel, we'll need to word it clear enough to explain what it is "Hide dictionary look-up radicals section" or something

@saxoncameron saxoncameron added python Involves work in Python requires discussion Either complex, underdeveloped, or possibly contentious labels Nov 4, 2021
@saxoncameron
Copy link
Contributor

Created #57 to separate the discussion/scope for any potential section show/hide.

Let's keep this issue scoped to just the display/hiding of the radicals section, which we can implement now. Can think of whether we want to implement something like #57 down the line.

@RicBent
Copy link
Contributor Author

RicBent commented Nov 13, 2021

Implemented with eb89bd3

@RicBent RicBent closed this as completed Nov 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancment of an existing feature python Involves work in Python requires discussion Either complex, underdeveloped, or possibly contentious
Projects
None yet
Development

No branches or pull requests

2 participants