Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Kanji lookup doesn't work from search inputs #83

Closed
saxoncameron opened this issue Nov 9, 2021 · 5 comments
Closed

[BUG] Kanji lookup doesn't work from search inputs #83

saxoncameron opened this issue Nov 9, 2021 · 5 comments
Assignees
Labels
lookup browser Pertains to the Kanji lookup browser python Involves work in Python

Comments

@saxoncameron
Copy link
Contributor

Kanji ctrl+shift+k hotkey lookup on highlighted text within search boxes doesn't work. It opens the lookup browser but doesn't search. Doesn't seem specific to Migaku Dictionary, it also doesn't work from the search input of the regular Ank card browser search box.

Searching from contents in Migaku Dictionary and the Anki card browser both work fine, it's just highlighted kanji from the search input.

Pasted_Image_10_11_21__9_07_am

@saxoncameron saxoncameron added lookup browser Pertains to the Kanji lookup browser python Involves work in Python labels Nov 9, 2021
@RicBent
Copy link
Contributor

RicBent commented Nov 13, 2021

Fixing this is near impossible actually. You cannot add application wide shortcuts in Qt.

I'd have to hook into every single ui component separately and add that feature. Currently it just works in all web views as those are a single Qt component (most of Anki is actually just webviews).

I think the best solution would be adding a system wide global hotkey to lookup Kanji. What do you think? Implementing that wouldn't take long as I already did that for the upcoming all-in-one add-on for interacting with the dictionary.

@saxoncameron
Copy link
Contributor Author

Not a big deal if this one can't be fixed. A system-wide global hotkey seems like a good compromise.

@RicBent
Copy link
Contributor

RicBent commented Nov 13, 2021

I was thinking about using Ctrl+Alt+K as the global hotkey. Can you check for me if that one is usable on macOS?

@saxoncameron
Copy link
Contributor Author

I'm personally using Ctrl+Option+K to cycle keyboard languages, but after some searching, it doesn't appear that's the default chord. I must have just made that up? So I think it's fine? 🤔 How big of a deal would it be to have it be configurable? That's something I always wish I could change, with the other Migaku Anki addon global hotkeys (like dictionary search).

@saxoncameron
Copy link
Contributor Author

This isn't a bug, and the above discussed feature I've opened a dedicated issue for here: #136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lookup browser Pertains to the Kanji lookup browser python Involves work in Python
Projects
None yet
Development

No branches or pull requests

2 participants