Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GTK3's Gtk.Application/Gtk.ApplicationWindow #178

Closed
krlmlr opened this issue Oct 25, 2022 · 3 comments · Fixed by #181
Closed

Use GTK3's Gtk.Application/Gtk.ApplicationWindow #178

krlmlr opened this issue Oct 25, 2022 · 3 comments · Fixed by #181

Comments

@krlmlr
Copy link
Contributor

krlmlr commented Oct 25, 2022

for native macOS menu.

Follow-up to #143 (comment).

@MightyCreak
Copy link
Owner

@krlmlr
Copy link
Contributor Author

krlmlr commented Oct 27, 2022

@hugoholgersson: Would you know what needs to be done here?

@hugoholgersson
Copy link
Contributor

No, I don't. I only made a similar note in #165 (comment) but I did not dig deeper.

It would be cool if you'd take a stab. I'd be happy to test and review a PR for this.

yuriiz pushed a commit to yuriiz/diffuse that referenced this issue Nov 6, 2022
yuriiz pushed a commit to yuriiz/diffuse that referenced this issue Nov 6, 2022
yuriiz pushed a commit to yuriiz/diffuse that referenced this issue Nov 8, 2022
yuriiz pushed a commit to yuriiz/diffuse that referenced this issue Nov 12, 2022
yuriiz pushed a commit to yuriiz/diffuse that referenced this issue Nov 12, 2022
@MightyCreak MightyCreak changed the title Use GTK3's GApplication/GtkApplication Use GTK3's Gtk.Application/Gtk.ApplicationWindow Nov 14, 2022
MightyCreak added a commit that referenced this issue Nov 21, 2022
* Use GTK3's GApplication/GtkApplication #178
* fix: remove icons in menu
* doc: update CHANGELOG.md
* chore(i18n): update po/diffuse.pot

Co-authored-by: Yurii Zolotko <yurii.zolotko@pm.me>
Co-authored-by: Romain Failliot <romain.failliot@foolstep.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants