Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCS support is broken #28

Closed
manuel-192 opened this issue Mar 20, 2020 · 10 comments
Closed

RCS support is broken #28

manuel-192 opened this issue Mar 20, 2020 · 10 comments

Comments

@manuel-192
Copy link

Diffuse no more shows differences for RCS files.

@UffeJakobsen
Copy link
Contributor

I guess that this is a duplicate of issue #26

And I guess that my pull request #27 will also fix your problem with RCS (I only tested my fix with GIT)

So now we are just waiting for the repo owner to integrate the pull requests.... :-)

@UffeJakobsen
Copy link
Contributor

BTW: if you use ArchLinux - they have integrated my patch into their package of diffuse

@MightyCreak
Copy link
Owner

I merged your PR @UffeJakobsen ;)

@manuel-192
Copy link
Author

Thanks!

@manuel-192
Copy link
Author

Hello again!
I still have the same RCS problem, it doesn't show the diffs. Do I have the correct version or am I missing something?
Command 'git describe --long --tags' shows
v0.5.0-alpha.7-8-gb1f7036

@MightyCreak
Copy link
Owner

What's your latest commit hash?

@MightyCreak
Copy link
Owner

Also, could you give me an example of RCS file please? I don't know this extension 😕

@manuel-192
Copy link
Author

I guess the hash is: b1f7036.

File 'foobar': http://ix.io/2fYx
File 'RCS/foobar,v': http://ix.io/2fYy

So the version control file is under the RCS folder. Command
diffuse foobar
does not show the diffs at all as it should.

@MightyCreak
Copy link
Owner

MightyCreak commented Jun 22, 2020

@manuel-192 I found the bug 🎉
You can see the commit description here: c5b0dc1

TL;DR: it was actually a bug from the original repo, introduced by r420 (a revision committed after the 0.4.8 release).

@manuel-192
Copy link
Author

manuel-192 commented Jun 23, 2020

Thanks! I'll try it here.

EDIT: It seems to work, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants