Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for components #17

Open
MightyJoeW opened this issue Oct 6, 2021 · 4 comments
Open

Add unit tests for components #17

MightyJoeW opened this issue Oct 6, 2021 · 4 comments
Assignees
@wsameer @pavittarx
Labels
hacktoberfest hacktoberfest-accepted

Comments

@MightyJoeW
Copy link
Owner

Add unit tests for components (preferably with Jest and React Testing Library)
@pavittarx
Copy link
Contributor

@MightyJoeW I would like to take this up. Please let me know about the folder structure or conventions that you may want to follow.

Thanks!

@MightyJoeW
Copy link
Owner Author

Thanks @pavittarx ! I'm open to whichever approach you'd like to take.

Typically, I'd create a folder for each component for the jsx file, the scss file, and the test file, but this is a bare-bones project. I'd be okay with a separate tests folder to house all of the tests. Up to you!

@pavittarx pavittarx mentioned this issue Oct 7, 2021
Merged
MightyJoeW pushed a commit that referenced this issue Oct 13, 2021
@pavittarx
#17 unit testing components (#25)
64d1c05 
* app tests added

* header tests added

* nav bar tested

* home component tested

* footer testing [WIP]

* footer testing complete

* tests added for about page

* fix react-ga, added user tests

* dev cards tests added

* error tested
@wsameer
Copy link

wsameer commented Oct 14, 2021

@MightyJoeW can I take this up and add tests for the remaining components?

@MightyJoeW
Copy link
Owner Author

@wsameer Yes! It would be great to continue adding test coverage for the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wsameer wsameer

@pavittarx pavittarx

Labels
hacktoberfest hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wsameer @MightyJoeW @pavittarx