Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default logging: level "WARNING" and up to the console #170

Closed
lucmurer opened this issue Nov 14, 2023 · 0 comments · Fixed by #172
Closed

Change default logging: level "WARNING" and up to the console #170

lucmurer opened this issue Nov 14, 2023 · 0 comments · Fixed by #172
Labels
enhancement New feature or request

Comments

@lucmurer
Copy link
Collaborator

At the moment we do not log anything if not explicitly requested. For some functionality this is sub-optimal, for example when just some tokens from the Hashicorp-Vault cannot be replaced. Should we exit then? Probably no. But with the current default logging configuration the user will not see any message about what went wrong with the devices where no data could be got.

So we should do the following:

  • Change the default log settings (if nothing else is configured or requested by command line) to "log to console" and level "WARNING".
  • Make sure, that the urllib & Co. logs do not spam our logs
  • Change the "enable logging" command line switch ("-l") to a "quiet" switch ("-q") to suppress logging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant