Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Reset PV Discovery" action #403

Open
sseago opened this issue Jul 30, 2019 · 2 comments
Open

"Reset PV Discovery" action #403

sseago opened this issue Jul 30, 2019 · 2 comments
Labels
icebox General backlog kind/feature Categorizes issue or PR as related to a new feature. sprint-candidate High priority icebox items that are good candidates for upcoming releases UXD Work requireing UX design attention

Comments

@sseago
Copy link

sseago commented Jul 30, 2019

We should consider implementing a "reset PV discovery" UI action. Since the controller chooses default storageclasses on the first pass, if the user realizes that there's a missing storageclass on dest (i.e. ceph isn't available, etc.) and adds it post-discovery, the controller won't overwrite the initial default values on the next pass since it has no way of knowing whether it's overwriting user-entered values. Adding a "reset" action, which would result in migplan update that removes the entire persistentVolumes array, would allow PV discovery to start over for the plan, selecting new defaults based on the newly-added storage classes.

@eriknelson eriknelson added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 30, 2019
@ibolton336
Copy link
Contributor

@sseago could we pass something to the api that would signify that we are rerunning PV discovery? We are using UI state to determine if we are rerunning pv discovery or if it being run for the first time on a mig plan. We could pass this flag to the back end if that could trigger a reset?

@eriknelson eriknelson added icebox General backlog sprint-candidate High priority icebox items that are good candidates for upcoming releases labels Feb 3, 2020
@eriknelson
Copy link
Contributor

We've implemented something like this on previous kubernetes controllers with a dedicated field that is a monotonically increasing value who's sole purpose is to force a re-reconcile.

Ex: relistPersistentVolumes: 0. Editing this value to 1 would force a refresh of the data. It can be done from the cli, or from the UI. I think this would be a useful feature as a "force refresh".

@eriknelson eriknelson added the UXD Work requireing UX design attention label Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icebox General backlog kind/feature Categorizes issue or PR as related to a new feature. sprint-candidate High priority icebox items that are good candidates for upcoming releases UXD Work requireing UX design attention
Projects
None yet
Development

No branches or pull requests

3 participants