registry-[planname] will not be removed on the source

[rbaumgar]

when you do a stage or migrate on the source cluster a pod with the name registry-[planname]-... will be created.
This pod will often not be removed, even when the plan will be deleted on mig-ui.
This leads to many unused pod on the source cluster when you create and use many plan.
Seen in OCP 4.2 and 4.3. CAM version 1.1.1

[eriknelson]

@rbaumgar Is your expectation that the source registry pod is closed at the conclusion of a stage or a migrate, in both an error or success scenario?

@sseago Unsure if this belongs in the controller repo or in the UI repo, I'm thinking this somewhat straddles both. We should define what the expected behavior here is under specific scenarios and can file implementation issues once that's clearly expressed.

[sseago]

The pod gets removed when the plan is closed. We had a lot of back-and-forth discussion around how to make sure plans get closed before removal. I'm not quite sure where the current functionality is here, but I thought the UI closed the plan before deleting it, while the API does not force closure before removal.

[sseago]

We no longer automatically close plans before deletion at the API level because that led to our finalizer hung namespace problem. I think at this point, the easiest thing would be to enforce closure before removal in the UI and document that any API-level plan deletion actions must be done after closing the plan. This becomes a bigger issue once we actually implement the cleanup actions on plan closure discussed in #679

[sseago]

"Is your expectation that the source registry pod is closed at the conclusion of a stage or a migrate, in both an error or success scenario" -- we should not delete this upon stage or migrate. With incremental migrations, the same migration registry would be used for each migration on a migplan. The current controller code creates the registry on plan open and deletes it on plan closure.