Integration tests are broken and unit tests are missing

[mturley]

Running yarn test fails with errors in both the cluster form spec and the storage form spec.

Jest is installed and configured, but no Jest tests exist. I think things like "has buttons disabled when input data is missing" are more easily implemented as Jest unit tests of the individual component, and integration tests should only test the interactions between different components.

Related to #310, but in addition to snapshot tests we should have smaller tests asserting specific things without a snapshot, e.g. we could shallow-render the form with input data missing and assert that the buttons have the isDisabled props set correctly. I'm open to debate how useful snapshot tests really are, anyway :)

[eriknelson]

This is two separate problems. There's a regression here where our travis CI should be failing every PR and it's not. Separately, the entire project is undertested and this is a known issue. We need to make it a priority to fix travis so that those tests are correctly failing if they are not passing our basic existing tests.

[gildub]

@mturley, as @eriknelson commented this are 2 separate issues.
Would it be okay to split it. Maybe keep this one for the broken integration tests issue and create another one for sub-snapshot tests?

[eriknelson]

I'd like to close this issue so we can open two new issues that accurately reflect where we are currently. The "integration tests" we a long time ago were really not accomplishing anything and so they sat and rotted. I pulled them and archived them.

We need two issues, one that documents our desired strategy for integration testing, and I have a pretty good idea what this needs to look like in the long run. Separately, as @mturley pointed out, it's time to get some snapshot testing in place where feasible. I'd like to schedule a meeting with the UI team to discuss these, and out of that meeting produce these issues with our documented conclusions. I will schedule something this week, it's going to be a longer discussion than we can handle on a scrum call.

[mturley]

Sounds good, thanks guys