Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an i18n solution #694

Open
mturley opened this issue Feb 21, 2020 · 1 comment
Open

Add an i18n solution #694

mturley opened this issue Feb 21, 2020 · 1 comment
Labels
icebox General backlog kind/feature Categorizes issue or PR as related to a new feature.

Comments

@mturley
Copy link
Collaborator

mturley commented Feb 21, 2020

Text in the UI is defined directly in React components as English-language strings.

If the intention is ever to add multi-language support, we should start using something like https://github.com/formatjs/react-intl (or investigate what others are using) to wrap strings in a function call that could return translated forms of the strings in the future. Even if we can't add the actual translations until much later, it would help to establish the usage of this kind of library so it is easier to add languages in the future.

@eriknelson
Copy link
Contributor

@jwmatthews is this a required feature?

@eriknelson eriknelson added kind/feature Categorizes issue or PR as related to a new feature. icebox General backlog labels Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icebox General backlog kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants