Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use appropriate alert types for controller errors #756

Open
vconzola opened this issue Mar 18, 2020 · 1 comment
Open

Use appropriate alert types for controller errors #756

vconzola opened this issue Mar 18, 2020 · 1 comment
Assignees
@gildub @vconzola
Labels
icebox General backlog low-hanging-fruit Small items good for quick fixes or new developers needs-ux-design Requires UX design, probably in the form of mocks, to be delivered to the issue release-1.3.0 UXD Work requireing UX design attention

Comments

@vconzola
Copy link
Collaborator

When the controller returns an error attempting to get cluster data (such as during PV discovery) and the user is blocked from continuing, the UI should display a modal alert rather than a toast or in-line alert.
pv discovery error
@vconzola vconzola added UXD Work requireing UX design attention icebox General backlog needs-ux-design Requires UX design, probably in the form of mocks, to be delivered to the issue labels Mar 18, 2020
@vconzola vconzola self-assigned this Mar 18, 2020
@ibolton336 ibolton336 added the low-hanging-fruit Small items good for quick fixes or new developers label Mar 24, 2020
@gildub gildub mentioned this issue Jun 3, 2020
Closed
@vconzola
Copy link
Collaborator Author

@gildub The wording might not be exactly right, but this is what we want this sort of message to look like. https://drive.google.com/file/d/1fvzeU0z3LpT3aHUxCHj3mURrXPF37KhO/view?usp=sharing Per PF content guidelines - it's friendly, it explains the issue, and it tells the user what action(s) they should take to resolve the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gildub gildub

@vconzola vconzola

Labels
icebox General backlog low-hanging-fruit Small items good for quick fixes or new developers needs-ux-design Requires UX design, probably in the form of mocks, to be delivered to the issue release-1.3.0 UXD Work requireing UX design attention
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

VolumesForm: Replace Bullseye with Modal to handle critical errors
4 participants
@jwmatthews @gildub @ibolton336 @vconzola