Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PaperMenu flies into screen from left side on firefox #1160

Closed
lucasmerat opened this issue Aug 17, 2020 · 10 comments
Closed

PaperMenu flies into screen from left side on firefox #1160

lucasmerat opened this issue Aug 17, 2020 · 10 comments

Comments

@lucasmerat
Copy link

Recently while testing our app in FireFox, we noticed that the paper menu component has an odd animation issue. The menu will fly in from the top left side of the screen. I tested this in multiple contexts and different usages of the paper menu component.

Note that this is an intermittent issue and happens most, but not all of the time.

Here is a link to a screen cap of the interation: https://drive.google.com/file/d/11hpsmaBOl2Pq45hA7OhrQuVAjIa7inrY/view?usp=sharing

@hergaiety
Copy link

hergaiety commented Aug 18, 2020

I see this happening consistently on https://miguelcobain.github.io/ember-paper/#/components/menu

Firefox 79.0 on Ubuntu

Attatching a few attempts at capturing it, but its very fast and difficult to record accurately.

Peek 2020-08-18 09-26

Peek 2020-08-18 09-25

@pax7
Copy link

pax7 commented Sep 12, 2020

I have a similar (if not the same) issue where basically the @position is only honored the first time and then it flies in from the left.

@CodingItWrong
Copy link

There are some notes in #1151 related to a suggested fix for this

@pax7
Copy link

pax7 commented Sep 16, 2020

I can confirm that this fixes flying from the left issue and the !paperElement issue:

if (!parentElement) {
      parentElement = document.getElementById('ember-basic-dropdown-wormhole');
    }

while this:
if (!parentElement) return;

only fixes the !paperElement issue.

@miguelcobain
Copy link
Owner

I released this fix on 1.0.0-beta.33. Can you please try if it works now and reopen if there is any further related problems?

Also, @hergaiety, the can you please retry the website on Ubuntu and see if it is fixed now?

@hergaiety
Copy link

@miguelcobain thanks for your attempts at resolving this! Alas I'm still seeing the same on the website and within our app when bumping to 1.0.0-beta.33.

@lucasmerat would you check on your end as well and reopen this if needed?

@lucasmerat
Copy link
Author

@hergaiety @miguelcobain Can confirm that I'm still seeing the issue on FireFox on the Ember Paper website and our app.

@CodingItWrong
Copy link

@lucasmerat Can you mark the GH issue as open for tracking?

Previously I saw this issue not only on Firefox but also Chrome and Safari iOS. With beta 33 I see Chrome and Safari iOS fixed, but not Firefox. Chrome:

chrome-works

Firefox:

firefox-does-not-work

@lucasmerat
Copy link
Author

@CodingItWrong I'm not sure I know how to reopen the issue. Looking for that feature but can't seem to find it.

@CodingItWrong
Copy link

@lucasmerat I googled around and every time someone asks how to reopen a GitHub issue, the responses are always whether they can, but they don't say how 😂 😭 - So I guess our comments on the thread should be enough 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants