Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

md-menu has outline issue after selected #679

Closed
iirving opened this issue Mar 20, 2017 · 4 comments
Closed

md-menu has outline issue after selected #679

iirving opened this issue Mar 20, 2017 · 4 comments

Comments

@iirving
Copy link
Contributor

iirving commented Mar 20, 2017

on my app, and the demo ember-paper app, after selecting a menu item I've been seeing a (blue) outline. (see attach image)
screen-cap-menu-outline

I've been able to corrent this by add to my app.scss:
md-menu { outline: none; }

as for doing a pr to fix this for everyone?
adding this to node_modules/angular-material-source/src/components/menu/menu.scss doesnt make sense.
would it make sense to add this fix to app/styles/ember-paper.sccs after the imports? if not there then where/how?

@miguelcobain
Copy link
Owner

Do you see this in angular material?
If not, how did they solve that?

@iirving
Copy link
Contributor Author

iirving commented Mar 20, 2017

not seeing this in the current am demo (https://material.angularjs.org/latest/demo/menu).

I'll look into how they solve it.

@miguelcobain
Copy link
Owner

Basically, we had tabindex="0" from ember-basic-dropdown and AM doesn't have any tabindex defined.
I changed it to -1 to make sure that element never gets focused (bypassing the focus to the nested button).

@iirving
Copy link
Contributor Author

iirving commented Mar 20, 2017

thks. yea i saw that it was a ":focus" issue for ep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants