Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customisation of each cell in a Section before its used #180

Closed
wants to merge 1 commit into from

Conversation

nicwise
Copy link

@nicwise nicwise commented Apr 21, 2013

this came out of my Evolve talk.

Allows a Section to customise its elements before they are used - so you can change the background of the element correctly without changing how the element works.

Another way could be to make the Section implement an interface like IElementResizing, not sure if an otherwise blank method call is quicker/better than a "if (x is ISectionCustomisation)" type call. Happy to rework if it is.

Should have submitted this a year ago. :(

…ized before it's used. Allows for consistent changes to a section, eg changing the background image
@nicwise
Copy link
Author

nicwise commented Apr 21, 2013

@migueldeicaza
Copy link
Owner

Is this related to one of the questions that folks asked at Evolve?

@nicwise
Copy link
Author

nicwise commented Apr 21, 2013

No. Something I demoed and have in a production app, but hadn't gotten to
submit as a pull request until now.

@migueldeicaza
Copy link
Owner

So this kind of customization should be done by a subclass of the source, there is no need to add this directly to the source code.

You are going from having to customize the internal data source, to having to customize a Section subclass. Small gain, but one that impacts every cell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants