Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Net 4.6 compatibility #258

Open
ghost opened this issue Apr 15, 2018 · 5 comments
Open

Net 4.6 compatibility #258

ghost opened this issue Apr 15, 2018 · 5 comments

Comments

@ghost
Copy link

ghost commented Apr 15, 2018

@migueldeicaza Is there a hard dependency anywhere in the code for NET 4.6.1 which is required by SystemValue tuple 4.4.0? Could we back level System.ValueTuple to 4.3.1 without breaking anything? Trying to make this package compatible with Unity which uses Net.Framework 4.6

"Warning The primary reference "TensorFlowSharp" could not be resolved because it was built against the ".NETFramework,Version=v4.6.1" framework. This is a higher version than the currently targeted framework ".NETFramework,Version=v4.6"."

@migueldeicaza
Copy link
Owner

I dont think so, you could try to lower the version number and submit a Pull Request, and that will validate the change.

@edwardyehuang
Copy link

Well, I did a simple approach to make it compatible with.NET.4.5 (Visual Studio 2013) for one of my customers. I recompiled the TensorflowSharp in 4.5 and replace the new 4.6.1 API with the code copied from .NET 4.6.1. However, it will be slower than the official .NET 4.6, technically speaking, but it worked.

@bendiy
Copy link

bendiy commented Aug 17, 2018

@edwardyehuang
Do you have this TensorflowSharp source in .NET 4.5 version anywhere? I checked your fork, but didn't see anything.

Thanks!

@narend
Copy link

narend commented Feb 1, 2019

I also need tensorflowsharp in 4.5 for a customer. @bendiy @edwardyehuang Do any of you have 4.5 version? I checked your forks, but did not find anything. If you don't have, I can take a shot at doing it.

@narend
Copy link

narend commented Feb 4, 2019

@migueldeicaza , most changes seem to be replacing tuples with Record<> class to make it build in 4.5. Shall I try this in my fork and would you be willing to take this change? We can look at conditional compilation as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants