Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove System.ValueTuple dependency from net471 nuget package #480

Closed
glopesdev opened this issue Apr 17, 2020 · 2 comments · Fixed by glopesdev/TensorFlowSharp#5
Closed

Comments

@glopesdev
Copy link

I believe it is not necessary to include System.ValueTuple as a dependency when targeting net471. Ideally this dependency would be included only for netstandard2.0 to prevent binding redirect conflicts (see dotnet/standard#543).

@glopesdev
Copy link
Author

Interestingly, removing System.ValueTuple entirely could be another option, as the project seems to build fine without it, even on netstandard2.0.

@glopesdev
Copy link
Author

glopesdev commented Apr 17, 2020

In fact, it seems we could go further and target netstandard2.0 only. It comes built-in from .NET 4.7.1 onwards: dotnet/standard#514

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant