Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mentions appear randomly late in the dedicated mentions screen #216

Open
mrvdb opened this issue Jun 12, 2014 · 9 comments
Open

Mentions appear randomly late in the dedicated mentions screen #216

mrvdb opened this issue Jun 12, 2014 · 9 comments

Comments

@mrvdb
Copy link

mrvdb commented Jun 12, 2014

When I get mentioned sometimes the notifier on top doesn't show an indicator until much, much later in time.
I've tried to find a pattern, but failed. Sometimes it's after a minute but I have seen it take as long as 4 to 6 hours.

What is the logic here so I can perform a test and give some useful analysis for the issue?

@miguelfreitas
Copy link
Owner

The logic is here:

https://github.com/miguelfreitas/twister-html/blob/master/js/twister_newmsgs.js#L22

I have seen problems too. I guess there is something buggy here.

The idea for testing if the (not yet known) mention time is > (lastmentiontime - 1 hour) is to prevent very old mentions which have already been discarded (thus not "known" anymore) from reappearing as "new". But we might just relax on this test and see what happens.

@miguelfreitas
Copy link
Owner

Of course the other possibility is that the sender may have failed to send/store the mention to the DHT network. In that case, his twisterd will be retrying it every hour.

@mrvdb
Copy link
Author

mrvdb commented Jun 12, 2014

In the latter case, it also won't appear in the normal timeline, correct? It does however, so I think the message as such has been propagating properly.

@miguelfreitas
Copy link
Owner

Not really. Timeline propagation uses "bittorrent", mentions use DHT/UDP.

@mrvdb
Copy link
Author

mrvdb commented Jun 12, 2014

Ah, learn something new every day :-)

@miguelfreitas
Copy link
Owner

:-) check this out http://twister.net.co/?attachment_id=355
of course i'm biased but i hope it will be an interesting read!

@mrvdb
Copy link
Author

mrvdb commented Jun 12, 2014

👍 (was on my reading list already ;-) )

@Erkan-Yilmaz
Copy link
Contributor

asking about status of this issue

(after getting link to here on my current problem:
http://skilledtests.com/wiki/Twister_experience#2015-07-31 )

@miguelfreitas
Copy link
Owner

I think it is worth noting somethings that have changed since this issue was created:

  1. the logic i've mentioned in Jun 12, 2014 is different now, which should fix some issues.
  2. twisterd now takes care of detecting your own mentions from the people you follow. this has some nice advantages: (a) faster mentioning update, doesn't have to go through DHT put/get and (b) in case someone is spamming you with thousands of mentions, you still get the mentioning from your friends. in other words: one may denial-of-service the "feature" of receiving mentions from unknown sources but not from the people you know.

ps: your observations from twister experiences are always very interesting. we should somehow link those (or reorganize into) our own wiki http://wiki.twister.net.co/w/start for documentation purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants