Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pass manager kwargs from namespace #1103

Conversation

devamin
Copy link

@devamin devamin commented Dec 22, 2022

WHY

I need to pass ignore_queue from namespace emit call.

WHAT

Pass kwargs from namespace emit to server emit

@miguelgrinberg
Copy link
Owner

Thanks, this looks good in principle, but passing kwargs is not a good solution, as it makes it much harder to properly document these calls. So I would like to request two things:

  1. Add any missing function arguments explicitly
  2. Update the docstrings accordingly

Do you think you can make these changes? Thanks!

@devamin
Copy link
Author

devamin commented Dec 26, 2022

You welcome, thanks for you for creating this library.
Yes I can handle these requirements.

@devamin
Copy link
Author

devamin commented Jan 20, 2023

@miguelgrinberg please let me know if all good, or there is something that I need to change/add.

@miguelgrinberg
Copy link
Owner

Thanks. There were a few missing things in this PR such as the same support for ignore_queue in send() and call(), and also the tests needed some updates to cope with these changes. I have committed a complete fix now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants