Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The documentation of server cookie argument seems outdated or incomplete #597

Closed
vldpro opened this issue Dec 23, 2020 · 0 comments
Closed
Assignees

Comments

@vldpro
Copy link

vldpro commented Dec 23, 2020

From the documentation of flask-socketio and python-socketio, the cookie argument can set only the name of a cookie.

:param cookie: Name of the HTTP cookie that contains the client session
id. If set to ``None``, a cookie is not sent to the client.
The default is ``'io'``.

However, in engineio docs it seems that we can set the cookie params (httponly, secure etc).

https://github.com/miguelgrinberg/python-engineio/blob/28fe975daf239a2612e59843f06c52a72cfea84b/engineio/server.py#L50-L57

I guess it would be nice for a developer to have the complete information about this argument in python-socketio/flask-socketio libraries because generally don't search engineio repo/documentation in order to find the actual information about class arguments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants