Catch TimeoutError #635
Closed
Catch TimeoutError #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any idea what's the equivalent error for |
|
No idea yet, I don't use async server :( It's unclear from the first glance and needs some investigation. |
|
By the way - It's very upsetting when thread dies, and the rest of the application continues to live. I'd fix that - register a callback to call if thread stop, or crash the whole app (in flask-socketio case) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some network problems could cause TimeoutError, but it isn't handled. Moreover, the thread dies silently without any attempts to recover.
The bug can be also reproduced by setting the socket timeout option in Redis URL.
Probably there are other exceptions that should be retried as well, e.g BusyLoadingError.