New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time does not match on compare #44

Closed

tobbenb opened this issue Jan 9, 2022 · 1 comment

tobbenb commented Jan 9, 2022

Describe the bug
When comparing two shots, the shots time does not match up. One of the shots are compressed on the timeline.
When looking at the two shots on their own, the shots time matches and Keith's shot runs 15 seconds longer.
In the compare it looks like my shot stops at 2 minutes.
If I compare two of my own shots, there are no issues with time being align

To Reproduce
Steps to reproduce the behaviour:

Go to https://visualizer.coffee/shots/22b1a96b-9bb8-456d-a6a6-18199453c9b7/compare/ea328381-d703-45fd-bed7-9fad41b0e43c

Expected behaviour
Shots should align on the timeline.

Screenshots

Desktop (please complete the following information):

OS: Pop OS
Browser Firefox 92.0 & Chromium 97.0.4692.71
Version [e.g. 22]

miharekar closed this as completed in

3a920ac

Owner

miharekar commented Jan 10, 2022

Hey, @tobbenb, thanks for reporting this!

@lessthanjoey figured out what the issue was. And from there it was only playing with maths until I got it working 😅

Should be fine now in both cases:

https://visualizer.coffee/shots/22b1a96b-9bb8-456d-a6a6-18199453c9b7/compare/ea328381-d703-45fd-bed7-9fad41b0e43c

https://visualizer.coffee/shots/ea328381-d703-45fd-bed7-9fad41b0e43c/compare/22b1a96b-9bb8-456d-a6a6-18199453c9b7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment