Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VisualizationRequest.KEY_NODE_NOT_REMOVABLE has no effect #68

Open
m0squito opened this issue Sep 21, 2020 · 1 comment
Open

VisualizationRequest.KEY_NODE_NOT_REMOVABLE has no effect #68

m0squito opened this issue Sep 21, 2020 · 1 comment

Comments

@m0squito
Copy link

m0squito commented Sep 21, 2020

I am trying to disable/hide the 'X' button in a VNode that is rendered in a VCanvas. Here's the code snippet that I wrote to do it:

DefaultValueObject dvo = new DefaultValueObject();
dvo.setValue(myObject);
VNode node = workflow.newNode(dvo);
node.getVisualizationRequest().set(VisualizationRequest.KEY_NODE_NOT_REMOVABLE, true);

Unfortunately, it has no effect. I have tried it both when creating the node, but also inside a custom class that extends the FXFlowNodeSkinBase.

Am I doing something wrong?

PS. Is this project still active?

@cbvms123
Copy link

cbvms123 commented Oct 4, 2020

I do think this is a bug.
The method FlowNodeWindow.setCloseableState is private and only called from FlowNodeWindow.setEditableState
so it looks while this fine grained control was forseen at some point it was never fully implemented. Nevertheless it should be rather straight forward to add this to the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants