Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme color inconsistency between navigation bars #704

Closed
6 tasks done
sam-gq opened this issue Apr 22, 2024 · 10 comments
Closed
6 tasks done

Theme color inconsistency between navigation bars #704

sam-gq opened this issue Apr 22, 2024 · 10 comments
Labels
Bug Something isn't working

Comments

@sam-gq
Copy link

sam-gq commented Apr 22, 2024

Steps to reproduce

The issue is occured in Android 9 (API 28)

  1. Open Mihon app (Beta) with v0.16.5-6648 (Releases/r6648)
  2. Go to More options > Settings > Appearance
  3. In the theme section, change any of the theme colors with dark theme applied. I choose Strawberry Daiquiri
  4. Back to the main library
  5. See the actual behavior

Expected behavior

It should be match the color scheme between the navigation bar and the system navigation before I update it from Mihon Beta v0.16.5-6639

(Sample image using Tachiyomi base)
Make sure to see it closely at the bottom. Use the Color Picker if you can't see the color closely on your screen.

See image

Screenshot_20240423-062841

Other images

Screenshot_20240423-062851

Screenshot_20240423-062918

Screenshot_20240423-062928

Actual behavior

On current version (Beta v0.16.5.6648)
The navigation bar and the system navigation gets a different color.

Show image

Screenshot_20240423-062811

Other images

Screenshot_20240423-062822

Screenshot_20240423-062944

Screenshot_20240423-062954

Crash logs

No response

Mihon version

Beta 0.16.5-6648

Android version

9 (API 28)

Device

Cherry_Mobile Omega X

Other details

No response

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
  • I have written a short but informative title.
  • I have gone through the FAQ and troubleshooting guide.
  • I have updated the app to version 0.16.5.
  • I have updated all installed extensions.
  • I will fill out all of the requested information in this form.
@sam-gq sam-gq added the Bug Something isn't working label Apr 22, 2024
@Smol-Ame
Copy link

Known issue with Material color implementation update, might be fixed with later updates

@MajorTanya
Copy link
Contributor

Did this change occur between the newest beta and the beta before it? Or did the change appear at some point before then?

@sam-gq
Copy link
Author

sam-gq commented Apr 22, 2024

Did this change occur between the newest beta and the beta before it? Or did the change appear at some point before then?

Before I update it from Beta v0.16.5-6639, I misunderstood

@MajorTanya
Copy link
Contributor

Did this change occur between the newest beta and the beta before it? Or did the change appear at some point before then?

Before I update it from Beta v0.16.5-6639, I misunderstood

So beta 6639 was okay and beta 6648 was bad?

@sam-gq
Copy link
Author

sam-gq commented Apr 22, 2024

Did this change occur between the newest beta and the beta before it? Or did the change appear at some point before then?

Before I update it from Beta v0.16.5-6639, I misunderstood

So beta 6639 was okay and beta 6648 was bad?

Not really, as stated by him:

Known issue with Material color implementation update, might be fixed with later updates

@MajorTanya
Copy link
Contributor

Did this change occur between the newest beta and the beta before it? Or did the change appear at some point before then?

Before I update it from Beta v0.16.5-6639, I misunderstood

So beta 6639 was okay and beta 6648 was bad?

Not really, as stated by him:

Known issue with Material color implementation update, might be fixed with later updates

I know, I'm just trying to see which beta version was the last good one for you

@sam-gq
Copy link
Author

sam-gq commented Apr 22, 2024

I know, I'm just trying to see which beta version was the last good one for you
the Beta v0.16.5-6639

Did this change occur between the newest beta and the beta before it? Or did the change appear at some point before then?

Before I update it from Beta v0.16.5-6639, I misunderstood

So beta 6639 was okay and beta 6648 was bad?

Not really, as stated by him:

Known issue with Material color implementation update, might be fixed with later updates

I know, I'm just trying to see which beta version was the last good one for you

Beta v0.16.5-6639

@FooIbar
Copy link
Contributor

FooIbar commented Apr 25, 2024

It's due to NavigationBar started to use the new SurfaceContainer roles since 1.3.0-alpha02.
So it won't get fixed until someone updates those color schemes.

@sam-gq
Copy link
Author

sam-gq commented May 19, 2024

Fixed after updating to Beta 0.16.5-6697

@sam-gq
Copy link
Author

sam-gq commented May 19, 2024

Fixed after updating to Beta 0.16.5-6697

*Some themes gets perfect color match between navigation and the system navigation, except:
• The default theme (Android <9)
• Green Apple
• Midnight Dusk
• Nord
• Tako

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants