New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG - Add Maintenance behaviour is inconsistent when no vehicle added to the app #261
Comments
@darrengillman yes this is an issue! But I'm going to be fixing this before shipping the app, by adding an onboarding view, that has the user enter their vehicle info. So this won't be an issue. I'll leave it open, and assign myself to this issue for now |
@mikaelacaron fair enough. And I was going to volunteer to fix it for you :-) Although will need to mod the maintenance view to cope with the user deleting their vehicles. Do you still want us to offer to pick up issues, or would you rather just ship now? |
If you could pick up #6 that would be great! (a person already did the work and the PR is closed, but there were some edits they never made in time, before Hacktoberfest ended) Overall I didn't really expect many people to keep contributing after Hacktoberfest, and yeah at the moment I might just pause most of the issues until I ship the app, because I'll be making some big changes. See #260 for the list of things I'll be doing before shipping |
@mikaelacaron apologies for dropping the ball on this. A third party API our primary business app uses withdrew it services without notice or documentation, so it's been a manic couple of weeks building an alternative solution. Fun though, in a type 2 way! |
No worries! I'll be picking this up when I implement the onboarding. I'm using #260 to track all the tasks left before I ship the app |
Describe the bug
When no vehicle has been added (or all vehicles have been deleted) the Add Maintenance view is available but is not fully functional as a vehicle is required to add a maintenance record.
As a consequence of this:
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Several possible behaviours (some app architecture-dependent):
In all instances, and as a minimum, the "Add" button should not enable until all the mandatory fields have been completed.
Screenshots
Device Info (please complete the following information):
Additional Context
N/A
The text was updated successfully, but these errors were encountered: