Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Support for request bundling #49

Closed
mikaeldui opened this issue Feb 6, 2022 · 0 comments
Closed

Support for request bundling #49

mikaeldui opened this issue Feb 6, 2022 · 0 comments
Labels
enhancement New feature or request riot games api

Comments

@mikaeldui
Copy link
Owner

mikaeldui commented Feb 6, 2022

Would improve performance for multiple queries against a platform/region far away.

Suggested implementation:

var req1 = new SummonerRequest("summonerA");
var req2 = new ChampMasteryRequest(hmmmm); // Placeholder value?

var results = await (new LeagueOfLegendsMultiRequestClient(Server.NA)).SendAsync(req1, req2);

Could this be solved by WebSocket support, #50 ?


For reference, here are the ping times to euw1.api.riotgames.com from location all around the world (https://tools.keycdn.com/ping):

image

@mikaeldui mikaeldui added riot games api enhancement New feature or request labels Feb 6, 2022
Repository owner locked and limited conversation to collaborators Feb 11, 2022
@mikaeldui mikaeldui converted this issue into discussion #61 Feb 11, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
enhancement New feature or request riot games api
Projects
None yet
Development

No branches or pull requests

1 participant