-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Squanmate should not put a space after a / when showing algorithms #45
Comments
Good suggestion. Originally putting a space like that was a hack to get the algorithm to wrap nicely. Now I have a more advanced solution to wrapping in mind so the space can be removed though. |
The idea with the asterisks and highlighting is to
|
I can make the highlighting a bit more subtle. I'll open another issue for that. |
I implemented this today too, but it isn't released yet. I made it so that each (1,2)/ (rotations and slice instructions) always sticks together when the algorithm doesn't fit on one line (is wrapped). With this I tried to make the algorithm displayed consistently, so the slice should never wrap to the start of the next line. |
Fixed by 1662529 and released in version 6.6 |
Squanmate always puts a space after a
/
in Sq1 notation. This has been bugging me a lot since I started using Squanmate but I was always too lazy to open an issue.E.g. when importing a scramble I enter
1,0/-1,0/
and after the import Squanmate displaysSo it is transformed to
(1,0)/ (-1,0)/
. Happens also in the algorithm shape visualizer and everywhere else where algs are shown. Either also make a space before the/
or neither before or after (I think I prefer the one without spaces. I tested both versions by changing the HTML with the DevTools and it is still readable without the spaces and more compact=better).Btw: I like the new asterisk that shows when we leave the cubeshape :) My hand/brain coordination already tells me this when reading the last numbers before we leave cubeshape because I’ve done thousands of scrambles but I still like it :)
Edit: ok just saw the highlighting. I don’t like that at all <.< Just because text selection can be done by the user and is used for something else already (a user action, not normally something an application does).
The text was updated successfully, but these errors were encountered: