Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove height=1 From TextBox Elements #500

Closed
MikaylaFischler opened this issue Jun 14, 2024 · 1 comment
Closed

Remove height=1 From TextBox Elements #500

MikaylaFischler opened this issue Jun 14, 2024 · 1 comment
Assignees
Labels
enhancement New feature or improvement graphics Graphics library and/or user interface
Milestone

Comments

@MikaylaFischler
Copy link
Owner

MikaylaFischler commented Jun 14, 2024

Now that constraints exist, this can be removed.

^.*TextBox\{((?!height=).)*$ saving this regex, it finds all the places that don't have height specified. These were fine, so this would be useful if modified to find the height = 1 entries.

Final regex:

  • Search: ^(.*TextBox\{.*),(height=1)(.*)$ UPDATED: ^(.*TextBox\{.*),(height=1([^\d]))(.*)$
  • Replace: $1$3 UPDATED: $1$3$4
@MikaylaFischler MikaylaFischler added enhancement New feature or improvement graphics Graphics library and/or user interface labels Jun 14, 2024
@MikaylaFischler MikaylaFischler added this to the Full Release milestone Jun 14, 2024
@MikaylaFischler MikaylaFischler added this to Backlog in Full Release Project Board via automation Jun 14, 2024
@MikaylaFischler MikaylaFischler self-assigned this Jun 14, 2024
@MikaylaFischler MikaylaFischler moved this from Backlog to To do in Full Release Project Board Jun 18, 2024
@MikaylaFischler
Copy link
Owner Author

MikaylaFischler commented Jun 30, 2024

Sizes before removal:

"sizes": {
    "manifest": 6459,
    "system": 1832,
    "common": 110709,
    "graphics": 222768,
    "lockbox": 34224,
    "reactor-plc": 135008,
    "rtu": 192120,
    "supervisor": 423836,
    "coordinator": 351295,
    "pocket": 201301
}

Sizes after:

"sizes": {
    "manifest": 6459,
    "system": 1832,
    "common": 110709,
    "graphics": 222768,
    "lockbox": 34224,
    "reactor-plc": 134675,
    "rtu": 191490,
    "supervisor": 423062,
    "coordinator": 349828,
    "pocket": 200230
}

MikaylaFischler added a commit that referenced this issue Jun 30, 2024
…-textbox-elements

#500 removed now redundant height=1 from TextBox elements
Full Release Project Board automation moved this from To do to Done Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement graphics Graphics library and/or user interface
Projects
Development

No branches or pull requests

1 participant