Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When a key triggers a commit while no candidate is selected, the cursor should **always** be corrected leftwards #227

Closed
mike-fabian opened this issue Aug 22, 2021 · 0 comments
Assignees

Comments

@mike-fabian
Copy link
Owner

Currently, when committing while no candidate is selected, the cursor is corrected lefwards only

  • if key.shift and key.val in self._keys_which_select_with_shift:

or:

  • elif (key.val in (IBus.KEY_Left, IBus.KEY_KP_Left, IBus.KEY_BackSpace)):

First of all, no distinction needs to be made between these two cases, the cursor can be adjusted leftwards to where the caret was in both these cases. So first of all, the code can be simplified.

Second, the cursor can, and should be adjusted leftwards even when other keys triggered the commit.

No matter what key triggered a commit (while no candidate was selected!), the cursor should end up where the caret was when the commit was triggered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant