Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] There should be a command commit_and_forward_key which can be bound to a key binding #461

Closed
mike-fabian opened this issue Aug 31, 2023 · 3 comments

Comments

@mike-fabian
Copy link
Owner

This is to make it possible to emulate ibus-m17n even more closely.

ibus-m17n commits the preedit when the Left is pressed (the arrow-left key) and it passes the Left key event through.

ibus-typing-booster already has a command commit which can be bound to a key but that command just commits and does not pass the key through (which is on purpose).

Therefore, binding commit to Left makes ibus-typing-booster commit on Left already just like ibus-m17n does, but the cursor is not moved left.

For example, when using hi-itrans with ibus-m17n typing a puts in the preedit. Then, typing Left commits the preedit so one gets |अ as the committed result (where | indicates the cursor position. Compare this to using hi-itrans with ibus-typing-booster while Left is bound to commit: Typing a puts into the preedit. Then typing Left commits but the cursor stays on the right side, so the final result is अ| (where | again indicates the cursor position).

If a new command commit_and_forward_key is introduced, one can bind Left to that command instead of to commit and then ibus-m17n and ibus-typing-booster behave exactly the same when pressing Left, commit and move the cursor left.

@mike-fabian
Copy link
Owner Author

Video showing the current behaviour:

Peek.2023-08-31.17-47.mp4

@mike-fabian mike-fabian added this to To do in Mike’s github project board via automation Aug 31, 2023
@mike-fabian
Copy link
Owner Author

See also: ibus/ibus#2536 (comment)

@mike-fabian
Copy link
Owner Author

Video showing the improved behaviour using the release candidate ibus-typing-booster-2.23.5 from

https://copr.fedorainfracloud.org/coprs/mfabian/ibus-typing-booster/build/6359615/

Peek.2023-08-31.18-51.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant