Labels not showing in Roundcube

[mkerstner]

Using RC 1.6.5 with PHP 8.2.x here.

While the plugin works to set the labels from both sides (TB and RC) unfortunately they only show in TB.

I've checked if they show in Classic and Larry -> in both they are only visible once when setting the label in RC.
But they are gone once the folder is refreshed.

There are no JS or PHP erros shown.

Could you provide any hints as to what might cause the issue here? Thanks a bunch for the plugin!

FYI: I'm already using the latest version with fix #79 included.

[mkerstner]

Update:

With further testing I can confirm that labels are showing/working correctly for all folders except INBOX.

Once I move an already flagged email from INBOX to any sub folder RC will show the TB flags correctly.
This also works when moving back to INBOX -> Then they also show for INBOX correctly.

-> But they don't show at all in INBOX by default, i.e. when they reach INBOX initially.

Anything that I can test here to provide further insights / solution paths?

Thanks

[mike-kfed]

I run RC 1.6.5 and PHP 8.2 on my live machine too, and I exclusively use the labels on the INBOX folder, without the described problem. Since I cannot reproduce your findings, I assume that it is either related to your IMAP server config, some short-coming of roundcube itself or maybe even a bug in this plugin based on that environment.
I'll happily accept a PR that fixes your problem, as long as it doesn't break anything for others.

[mkerstner]

Are you using dovecot by any chance? If so, could you please share your configuration? I would check it from this perspective and then continue debugging. Thanks

[mike-kfed]

I am using dovecot 2.3 with maildir storage, the config is the default that comes with Debian 12, the only thing I adapted are the user lookups, they are coming from a sql database. But the latter has no impact on how the inbox is handled, so sharing my config is not needed, just inspect the .deb file.

[c-schwamborn]

I think the issue is in function set_flags, on my system (bookworm with stock plugins) around line 318 (328 in the current git code). there is a definition $imap = $this->rc->imap;. The object $this->rc->imap seems to be renamed to $this->rc->storage. Changing this one line fixed the issue for me.
Otherwise I got an error like this, trying to set a message Flag:
[05-Apr-2024 15:09:03 UTC] PHP Warning: Undefined property: rcmail::$imap in /usr/share/roundcube/plugins/thunderbird_labels/thunderbird_labels.php on line 318
[05-Apr-2024 15:09:03 UTC] PHP Fatal error: Uncaught TypeError: array_merge(): Argument #1 must be of type array, null given in /usr/share/roundcube/plugins/thunderbird_labels/thunderbird_labels.php:327

[mike-kfed]

I think the issue is in function set_flags, on my system (bookworm with stock plugins) around line 318 (328 in the current git code). there is a definition $imap = $this->rc->imap;. The object $this->rc->imap seems to be renamed to $this->rc->storage.

You are clearly not using the latest thunderbird labels release 1.6.1

roundcube-thunderbird_labels/thunderbird_labels.php

Line 325 in 77b59eb

$imap = $this->rc->storage;

this line was fixed in january 2023 to use storage instead of imap. I am not sure how your comment is helping with the issue at hand?

[c-schwamborn]

Yeah, sorry for the post. I was a bit tired when I compared the code from the debian package with the git code. Later I discovered my mistake. Sadly the maintainer know about the patch but, for what ever reason, leave the current bookworm stable packages in that broken state. So discard my comment :-)

…

On 06/04/2024 13.19, Michael Kefeder wrote: > I think the issue is in `function set_flags`, on my system (bookworm with stock plugins) around line 318 (328 in the current git code). there is a definition `$imap = $this->rc->imap;`. The object `$this->rc->imap` seems to be renamed to `$this->rc->storage`. You are clearly not using the latest thunderbird lables release 1.6.1 https://github.com/mike-kfed/roundcube-thunderbird_labels/blob/77b59ebb606c9185a2e2b8ee339ed13b2c36e1fb/thunderbird_labels.php#L325 this line was fixed in january 2023 to use storage instead of imap. I am not sure how your comment is helping with the issue at hand?