Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js 13: ReadStream.prototype.open() is deprecated #15

Closed
janokacer opened this issue Oct 29, 2019 · 2 comments
Closed

Node.js 13: ReadStream.prototype.open() is deprecated #15

janokacer opened this issue Oct 29, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@janokacer
Copy link

janokacer commented Oct 29, 2019

ReadStream.prototype.open() has been deprecated in Node.js 13.0.1. I think this is the reason why WriteStream.prototype.createReadStream() causes: "RangeError: Maximum call stack size exceeded".

Code to reproduce:

const {WriteStream} = require('fs-capacitor')
const fs = require('fs')

const stream = fs.createReadStream('package-lock.json')
const capacitor = new WriteStream()

stream.pipe(capacitor)
capacitor.createReadStream()
@mike-marcacci mike-marcacci added the bug Something isn't working label Oct 29, 2019
@mike-marcacci
Copy link
Owner

Thanks for the report @janokacer. I'm planning to take the approach suggested by @ronag in #14, and will probably cut a major version sometime this week to more closely match the API changes in node 13.

@mike-marcacci
Copy link
Owner

This should be fixed in version 3, and also in the version 4 beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants