Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when running tests #35

Closed
dustinfarris opened this issue Jul 26, 2016 · 4 comments
Closed

Error when running tests #35

dustinfarris opened this issue Jul 26, 2016 · 4 comments

Comments

@dustinfarris
Copy link
Contributor

Running ember test on my local gives this error:

Cannot find module 'os-locale/' from '/Users/dustin/Archive/ember-materialize-shim/node_modules/yargs/'
Error: Cannot find module 'os-locale/' from '/Users/dustin/Archive/ember-materialize-shim/node_modules/yargs/'
    at Function.module.exports [as sync] (/Users/dustin/Archive/ember-materialize-shim/node_modules/resolve/lib/sync.js:33:11)
    at resolvePkg (/Users/dustin/Archive/ember-materialize-shim/node_modules/hash-for-dep/lib/resolve-pkg.js:20:18)
    at pkg (/Users/dustin/Archive/ember-materialize-shim/node_modules/hash-for-dep/lib/pkg.js:17:20)
    at again (/Users/dustin/Archive/ember-materialize-shim/node_modules/hash-for-dep/lib/deps-for.js:18:22)
    at /Users/dustin/Archive/ember-materialize-shim/node_modules/hash-for-dep/lib/deps-for.js:27:7
    at Array.forEach (native)
    at again (/Users/dustin/Archive/ember-materialize-shim/node_modules/hash-for-dep/lib/deps-for.js:26:55)
    at /Users/dustin/Archive/ember-materialize-shim/node_modules/hash-for-dep/lib/deps-for.js:27:7
    at Array.forEach (native)
    at again (/Users/dustin/Archive/ember-materialize-shim/node_modules/hash-for-dep/lib/deps-for.js:26:55)
    at /Users/dustin/Archive/ember-materialize-shim/node_modules/hash-for-dep/lib/deps-for.js:27:7
    at Array.forEach (native)
    at again (/Users/dustin/Archive/ember-materialize-shim/node_modules/hash-for-dep/lib/deps-for.js:26:55)
    at /Users/dustin/Archive/ember-materialize-shim/node_modules/hash-for-dep/lib/deps-for.js:27:7
    at Array.forEach (native)
    at again (/Users/dustin/Archive/ember-materialize-shim/node_modules/hash-for-dep/lib/deps-for.js:26:55)
    at /Users/dustin/Archive/ember-materialize-shim/node_modules/hash-for-dep/lib/deps-for.js:27:7
    at Array.forEach (native)
    at again (/Users/dustin/Archive/ember-materialize-shim/node_modules/hash-for-dep/lib/deps-for.js:26:55)
    at depsFor (/Users/dustin/Archive/ember-materialize-shim/node_modules/hash-for-dep/lib/deps-for.js:29:4)
    at statPathsFor (/Users/dustin/Archive/ember-materialize-shim/node_modules/hash-for-dep/lib/stat-paths-for.js:14:15)
    at hashForDep (/Users/dustin/Archive/ember-materialize-shim/node_modules/hash-for-dep/index.js:15:21)

I poked around yargs a bit and haven't found anything obvious. Will continue to investigate.

@mike-north
Copy link
Owner

rm -rf node_modules/yargs and reinstall. It should work. Still tracking down exactly what the problem is here before merging into materialize v0

@dustinfarris
Copy link
Contributor Author

dustinfarris commented Jul 27, 2016

yargs 3.27.0 is installed when running npm install. For some reason npm is skipping os-locale and y18n even though they are listed as dependencies.

npm list | grep yargs

│ │ │ │ │ └─┬ yargs@3.27.0
│   │ └─┬ yargs@3.10.0
    └─┬ yargs@4.8.1
      └─┬ yargs-parser@2.4.1
npm ERR! missing: os-locale@^1.4.0, required by yargs@3.27.0
npm ERR! missing: y18n@^3.2.0, required by yargs@3.27.0

@dustinfarris
Copy link
Contributor Author

Uninstalling and reinstalling yargs installs 4.8.1, and installs the dependencies as you would expect.

There doesn't seem to be a difference in how yargs 3.27.0 and 4.8.1 reference these two dependencies, so I'm left scratching my head here.

https://github.com/yargs/yargs/blob/v3.27.0/package.json
https://github.com/yargs/yargs/blob/v4.8.1/package.json

@mike-north
Copy link
Owner

@dustinfarris did you try adding these dependencies explicitly to this library? We shouldn't have to, but if it gets rid of this problem, we can do it temporarily and create a TODO to dive deeper later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants