Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running npm test for specific module/suite is running all tests #191

Closed
11 tasks done
the-other-nick-wilson opened this issue Jan 11, 2019 · 1 comment
Closed
11 tasks done
Labels
v1 Workshop v1

Comments

@the-other-nick-wilson
Copy link

  • System Information

    • Browser type and version: Chrome Version 71.0.3578.98 (Official Build) (64-bit)
    • OS type and version: MacOS X Mojave 10.14.2
    • Node version: 6.5.0
    • Any error messages that may be in the console where you ran npm start: None
    • Any error messages in the JS console: None
  • Describe the bug
    When trying to run specific module tests, it is running all test suites instead.

  • To Reproduce
    Steps to reproduce the behavior:

  1. Go to the root directory of the project.
  2. Run: npm test dealer
  3. Note the output which says:
./node_modules/.bin/jest --no-cache --watch $2
  1. Note that all test suites ran:
Test Suites: 1 failed, 2 passed, 3 total
Tests:       8 failed, 24 passed, 32 total
Snapshots:   0 total
Time:        2.083s
Ran all test suites related to changed files.
  • Expected behavior
    When running for a specific suite, it should obviously only run that suite. You can hack this by giving a dummy 1st argument to the "test" command: npm test fjksdlfjds dealer

This results in only the dealer suite being ran:
image

  • Screenshots (optional)
    Screenshot of all tests being run:
    image

  • Additional context
    See this issue which talks about the same thing near the bottom. I think the issue was closed addressing only the initial problem. Also see this possibly related issue.

Perhaps the $2 argument in scripts/test/index.sh is supposed to be $1?

@mike-north mike-north added the v1 Workshop v1 label Mar 8, 2019
@mike-north
Copy link
Member

Closing this issue because we've released a new version of the TypeScript course, where this is not a problem anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1 Workshop v1
Projects
None yet
Development

No branches or pull requests

2 participants