Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-pe-show-related attribute gets ignored and forces related videos. #16

Closed
pdramos1 opened this issue Jul 29, 2014 · 1 comment
Closed
Assignees
Labels
Milestone

Comments

@pdramos1
Copy link

The obj.attr('data-pe-show-related') returns a string so the if statement always fails if
you are using attributes for driving your prettyembed.
Below is a suggested fix to move the attr to be evaluated against string vs boolean for the attribute string creation.

if ( (obj.attr('data-pe-show-related') === 'false') || (options.showRelated === false) ) { playerOptions += '&rel=0'; } else { playerOptions += '&rel=1'; }

@mike-zarandona mike-zarandona added this to the v1.1.1 milestone Jul 30, 2014
@mike-zarandona mike-zarandona self-assigned this Jul 30, 2014
@mike-zarandona
Copy link
Owner

Thanks @pdramos1 - I'll be pushing an updated shortly (v1.1.1) to address a few outstanding issues. I'll be testing out your suggested fix and pull it in if all goes well. Thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants