Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not installed on laravel 5.4 #300

Closed
achalj09 opened this issue Feb 18, 2017 · 10 comments
Closed

Not installed on laravel 5.4 #300

achalj09 opened this issue Feb 18, 2017 · 10 comments
Labels

Comments

@achalj09
Copy link

can you please upgrade to compatable for laravel 5.4

@Stenerson
Copy link
Collaborator

Hi @achalj09,
Can you provide some additional details? What's making this library incompatible with Larvel? Are you getting errors? Is there any other information that could help us understand what specific issues you're having?

Thanks!

@achalj09
Copy link
Author

Hello @Stenerson

Thank you for quick your reply.

I have installed laravel 5.4 also for token authorisation I have used Laravel Passport so after passport installation if we installed your Plugin it gives error see in screen shot

untitled

Please check it out, it might be guzzle version problem.

Thank You.

@achalj09
Copy link
Author

Also I installed it new fresh project of laravel, it successfully installed but after that Laravel Passport is not installed for guzzle version problem. See the screen shot

untitled

@Stenerson
Copy link
Collaborator

Hi @achalj09,
Thanks for the additional information. It looks like the version of guzzle that we're dependent on (used in the ApiConnector) is a little out of date which is causing your issue.

We'll probably need @mike42 to weigh in. I'm not familiar with guzzle so I'm not sure if it can easily be updated or allow multiple versions.

@achalj09
Copy link
Author

achalj09 commented Mar 2, 2017

Hello @Stenerson
Thanks for your comments, my issue is not solve yet, I am eagrly waiting to comment of @mike42 for guidence

@Stenerson
Copy link
Collaborator

@achalj09, a few ideas...

  • Install the library manually instead of using composer. This isn't ideal but if you need it urgently it would work. You could always switch back to use composer when this is addressed.
  • Fork this repo and update the guzzler dependency to 6.6.2. Then you can import your repo from composer.

These options would at least buy you some time to test, etc. on your project until we hear from @mike42. If you went with the second option you could even test the API connector and submit a PR with the updated composer.json file. Just a thought 😉

@mike42
Copy link
Owner

mike42 commented Mar 3, 2017

Marking this as a bug. The guzzle dependency is too strict, and needs to be widened or made optional.

The ApiConnector was only added in the most recent release, so mike42/escpos-php v1.4.2 should avoid the issue if you want to get running immediately.

@Stenerson
Copy link
Collaborator

The 'ApiConnector' was only added in the most recent release, so 'mike42/escpos-php v1.4.2' should avoid the issue if you want to get running immediately.

This is a much better suggestion than either of mine! 😂
Thanks @mike42

@achalj09
Copy link
Author

achalj09 commented Mar 8, 2017

Hello @mike42 and @Stenerson thank you for your comments.

And finally its installed and work fine with v1.4.2

Although current version have same problem.

Thanks once again both of you !!!

@mike42
Copy link
Owner

mike42 commented Mar 12, 2017

The fix has now been released as 1.5.1.

I don't use Laravel myself but the dependencies are now much more relaxed. I'll close this off in a few days if there's no reports that it's still broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants