Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should this be Block.create() ? #1

Open
DougAnderson444 opened this issue Aug 21, 2022 · 0 comments
Open

Should this be Block.create() ? #1

DougAnderson444 opened this issue Aug 21, 2022 · 0 comments

Comments

@DougAnderson444
Copy link

DougAnderson444 commented Aug 21, 2022

return Block.decode({ bytes, cid, codec, hasher })

The params for decode are

decode = async ({ bytes, codec, hasher })

But the params used match create:

create = async ({ bytes, cid, hasher, codec })

Both return the same Promise<Block<T>>, so the tests would pass, but create validates the hash whereas decode does not, I presume validation was your intention?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant