Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add maxRedirects to throw error on redirect loops #9

Closed
Marak opened this issue Jan 9, 2011 · 1 comment
Closed

add maxRedirects to throw error on redirect loops #9

Marak opened this issue Jan 9, 2011 · 1 comment

Comments

@Marak
Copy link

Marak commented Jan 9, 2011

it's possible to get stuck in a redirect loop and request never fires its error handling.

this behavior is somewhat confusing as a user has no idea they are in a redirect loop.

maxRedirects should default to a relatively low number, and then fire callback with max redirects error.
@mikeal
Copy link
Owner

mikeal commented Jan 21, 2011

maxRedirects is current set to 10, the problem was that we weren't actually throwing when exceeding the max redirects.

Fixed in master, emits error on the client object when exceeding maxRedirects so it can be handled either on the client object or in the request callback.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikeal @Marak