Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document support browser versions #29

Open
JamesMGreene opened this issue Sep 12, 2017 · 6 comments
Open

Document support browser versions #29

JamesMGreene opened this issue Sep 12, 2017 · 6 comments

Comments

@JamesMGreene
Copy link

Please document the support browser and Node versions.

At least for the browsers, I believe this to be very limited given there isn't any employment of a browser-side polyfill here if the Fetch API is not available. I think many people would be surprised by that when coming to the "spiritual successor of request". Granted, that issue could be solved by incorporating something like #27 (using isomorphic-fetch rather than just node-fetch) if desired.

@gr2m gr2m changed the title Document the support browser and Node versions Document support browser versions May 27, 2018
@gr2m
Copy link
Collaborator

gr2m commented May 27, 2018

For node it would be sufficient to add "The latest Node LTS version is supported" and link to https://github.com/nodejs/Release#lts-schedule.

For browsers I’d say it’s safe to say that all browsers are supported. IE 11 and Opera Mini need a fetch polyfill. Maybe link to https://caniuse.com/#feat=fetch and for the browser support (as well as react native) link to https://www.npmjs.com/package/whatwg-fetch for a polyfill

@ljharb
Copy link

ljharb commented May 28, 2018

If all browsers are supported, then why not all nodes?

@gr2m
Copy link
Collaborator

gr2m commented May 28, 2018

*All evergreen browsers are supported.

If all browsers are supported, then why not all nodes?

Read more about the motivation here: Stop supporting old releases

r2/.travis.yml

Lines 6 to 8 in 0a93782

node_js:
# https://medium.com/@mikeal/stop-supporting-old-releases-70cfa0e04b0c
- 'lts/*'

It's not that I wouldn’t support all Node versions, but I wouldn’t do it ourselves. But we could add a way for others to sign up to support older Node versions and backport new features / fixes

@ljharb
Copy link

ljharb commented May 28, 2018

Yes, I’m familiar with that article and position, and think it’s hugely harmful to the ecosystem - but that philosophy also indeed means all evergreen browsers, which would mean no IE or Opera whatsoever. Why support those if not older nodes?

@gr2m
Copy link
Collaborator

gr2m commented May 28, 2018

Good point, thanks Jordan!

Let’s not officially support IE or Opera. It could work with a fetch polyfill, but no guarantees.

@ljharb
Copy link

ljharb commented May 28, 2018

At least that will be consistent :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants