Skip to content

Commit

Permalink
Let's see how we do with only the main guard.
Browse files Browse the repository at this point in the history
  • Loading branch information
mikeal committed Jun 18, 2013
1 parent 24031e9 commit c116920
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,7 @@ Request.prototype.init = function (options) {
}
}

self.once('pipe', function (src) {
self.on('pipe', function (src) {
if (self.ntick && self._started) throw new Error("You cannot pipe to this stream after the outbound request has started.")
self.src = src
if (isReadStream(src)) {
Expand All @@ -405,9 +405,9 @@ Request.prototype.init = function (options) {
}
}

self.on('pipe', function () {
console.error("You have already piped to this stream. Pipeing twice is likely to break the request.")
})
// self.on('pipe', function () {
// console.error("You have already piped to this stream. Pipeing twice is likely to break the request.")
// })
})

process.nextTick(function () {
Expand Down

6 comments on commit c116920

@OscarGodson
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why comment out the code? Is that for reference or something?

@mikeal
Copy link
Member Author

@mikeal mikeal commented on c116920 Jun 18, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, i may put it back. if nobody finds an issue with it i'll be removing it before publishing tho.

@kenperkins
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any feedback on this change yet?

@mikeal
Copy link
Member Author

@mikeal mikeal commented on c116920 Jul 4, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no issues so far, but i don't think it has gone out in a release. i'll push one friday if someone reminds me :)

@OscarGodson
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikeal K, tis friday :)

@mikeal
Copy link
Member Author

@mikeal mikeal commented on c116920 Jul 5, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

released.

Please sign in to comment.