Properly set cookies during redirects

request · Mar 14, 2012 · fddbd6e · fddbd6e
1 parent 3b9f0fd
commit fddbd6e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/main.js b/main.js
@@ -171,7 +171,7 @@ Request.prototype.init = function (options) {
     self.setHost = true
   }
 
-  self.jar(options.jar)
+  self.jar(self._jar || options.jar)
 
   if (!self.uri.pathname) {self.uri.pathname = '/'}
   if (!self.uri.port) {

diff --git a/tests/test-redirect.js b/tests/test-redirect.js
@@ -20,7 +20,10 @@ s.listen(s.port, function () {
 
     s.on('/'+label, function (req, res) {
       hits[label] = true;
-      res.writeHead(code, {'location':server + '/'+landing})
+      res.writeHead(code, {
+        'location':server + '/'+landing,
+        'set-cookie': 'ham=eggs'
+      })
       res.end()
     })
 
@@ -32,7 +35,8 @@ s.listen(s.port, function () {
         return;
       }
       // Make sure the cookie doesn't get included twice, see #139:
-      assert.equal(req.headers.cookie, 'foo=bar; quux=baz');
+      // Make sure cookies are set properly after redirect
+      assert.equal(req.headers.cookie, 'foo=bar; quux=baz; ham=eggs');
       hits[landing] = true;
       res.writeHead(200)
       res.end(landing)