Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Request class #542

Merged
merged 1 commit into from
May 4, 2013
Merged

Expose Request class #542

merged 1 commit into from
May 4, 2013

Conversation

regality
Copy link
Contributor

@regality regality commented May 3, 2013

This exposes the Request class so that the following is possible:

var request = require('request');

// disable strictSSL globally
request.Request.prototype.strictSSL = false;

Currently, this is only possible with request.defaults(), which is rather cumbersome when request is used in a lot of different places.

mikeal added a commit that referenced this pull request May 4, 2013
@mikeal mikeal merged commit 78b7a0a into request:master May 4, 2013
@mikeal
Copy link
Member

mikeal commented May 4, 2013

keep in mind that setting that property is unlikely to truly be global since different dependencies will get their own versions of request.

@ebdrup
Copy link

ebdrup commented May 7, 2013

What's the release plan? When can I expect this to make it to npm? :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants