Global agent is being used when pool is specified #596
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When making a request of the form
this.agent is still being set to this.httpModule.globalAgent, and then the global maxSockets is being overwritten with whatever is specified for the pool, which, in this case, is 1.
I'm not sure if this is the best way to check for this, but this change does fix the issue while still leaving an undefined pool as using the global agent and a false agent as not using a pool.