Send random cnonce for HTTP Digest requests #630
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My real problem is that passport-http interprets cnonce="" as an undefined cnonce.
From my understanding of cnonce, it is best to send a random cnonce with every request to make it harder to use a rainbow-table based attack against the hash.
So, I offer this patch in the hopes of solving my original problem, while also making request's digest implementation more complete.
Cheers,
William