Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send random cnonce for HTTP Digest requests #630

Merged
merged 4 commits into from Aug 16, 2013
Merged

Send random cnonce for HTTP Digest requests #630

merged 4 commits into from Aug 16, 2013

Conversation

ghost
Copy link

@ghost ghost commented Aug 16, 2013

My real problem is that passport-http interprets cnonce="" as an undefined cnonce.

From my understanding of cnonce, it is best to send a random cnonce with every request to make it harder to use a rainbow-table based attack against the hash.

So, I offer this patch in the hopes of solving my original problem, while also making request's digest implementation more complete.

Cheers,
William

mikeal added a commit that referenced this pull request Aug 16, 2013
Send random cnonce for HTTP Digest requests
@mikeal mikeal merged commit 21a6357 into request:master Aug 16, 2013
@sberryman
Copy link

Any chance of publishing a new version with these changes?

I'm also experiencing a problem when a server is returning:
qop="auth, auth-int"

Full header:
'www-authenticate': 'Digest realm="XXX", nonce="XXX", qop="auth, auth-int"'

It only appears to work when I use qop="auth" in the authHeader, If I leave qop="auth, auth-int" it will fail every time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants