Travis CI support #683
Merged
Travis CI support #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The callback is called twice and the second time a "ECONNRESET" error is passed which previously broke the test.
|
the email i got on this showed that the build failed, any idea why? |
|
That is probably related to my first try before I wrote e8dbcc8. The last mail should have stated that the build is now fixed. Sorry for spaming your mailbox, I wasn't aware that it was sending mails to you too. The mails can be deactivated or configured to be only sent on failure. |
|
@mikeal in case you're not familiar with Travis CI: you might have to login there and enable it for this repo. I only enabled it for my forked repo and will switch that off as soon as I know that it's working properly here. |
|
enabled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for Travis CI and fixed the failing unit test in test-timeout.js (see e8dbcc8)