Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance redirect handling #81

Merged
merged 1 commit into from
Sep 28, 2011
Merged

Conversation

danmactough
Copy link
Contributor

Enhance redirect handling: (1) response._redirectsFollowed reports the total number of redirects followed instead of being reset to 0; (2) add response.redirects, an array of the response.statusCode and response.headers.location for each redirect.

…e total number of redirects followed instead of being reset to 0; (2) add response.redirects, an array of the response.statusCode and response.headers.location for each redirect.
@mikeal
Copy link
Member

mikeal commented Sep 20, 2011

looks good, I'm on planes for the next few days so it might take me a bit to get it merged.

can you verify that all the tests are passing?

@danmactough
Copy link
Contributor Author

tests/run.sh
tests/test-body.js
options.requestBodyStream is deprecated, please pass the request object to stream.pipe.
8 tests passed.
tests/test-errors.js
All tests passed.
tests/test-pipes.js
All tests passed.
tests/test-timeout.js
All tests passed.

P.S. Safe travels

@danmactough
Copy link
Contributor Author

Bump

mikeal added a commit that referenced this pull request Sep 28, 2011
@mikeal mikeal merged commit 646c80d into request:master Sep 28, 2011
@mikeal
Copy link
Member

mikeal commented Sep 28, 2011

thanks for the reminder :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants