Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regex assumes alphanumeric seriesID; fails for those where "-" present #33

Closed
bikeactuary opened this issue Feb 4, 2022 · 2 comments
Closed

Regex assumes alphanumeric seriesID; fails for those where "-" present #33

bikeactuary opened this issue Feb 4, 2022 · 2 comments

Comments

@bikeactuary
Copy link
Contributor

need to modify here

blsAPI/R/blsAPI.R

Line 73 in 526cddf

m <- regexpr('\\"seriesid\\":\\"[a-zA-Z0-9]*\\",', payload)

@bikeactuary bikeactuary mentioned this issue Feb 4, 2022
Merged
@mikeasilva
Copy link
Owner

Merged in PR. Thanks for the fix!

@hedgeye-mbarr
Copy link

Merged in PR. Thanks for the fix!

thx - plz remember to tag latest release. I reference these in a dockerfile I have in a prod pipeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mikeasilva @bikeactuary @hedgeye-mbarr